Skip to content

Conversation

@spaze
Copy link
Owner

@spaze spaze commented Nov 25, 2025

No description provided.

@spaze spaze requested a review from Copilot November 25, 2025 20:10
@spaze spaze self-assigned this Nov 25, 2025
@spaze spaze marked this pull request as ready for review November 25, 2025 20:10
@spaze spaze merged commit 5474cc7 into main Nov 25, 2025
7 checks passed
@spaze spaze deleted the spaze/php-8.5 branch November 25, 2025 20:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to upgrade the application from PHP 8.4 to PHP 8.5. However, PHP 8.5 does not exist as of January 2025. PHP 8.4 (released November 2024) is the latest stable version in the PHP 8.x series. The changes are otherwise consistent across all configuration files.

Key Changes:

  • Updated PHP-FPM socket paths in production and development configurations
  • Updated Nginx FastCGI configuration to reference new socket path
  • Modified GitHub Actions test matrix to use the specified PHP version

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
conf/php/prod-canhas.report.conf Updated PHP-FPM socket path from php8.4 to php8.5
conf/php/dev-canhas.report.conf Updated PHP-FPM socket path from php8.4 to php8.5
conf/nginx/common-php.conf Updated FastCGI socket path from php8.4 to php8.5
.github/workflows/tests.yml Updated test matrix PHP version from 8.4 to 8.5 across all three jobs (info, lint, test)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants