[stree] stree to SDFG fixes from NASA branch#2420
Open
romanc wants to merge 6 commits into
Open
Conversation
make sure to be backwards compatible
Names/Labels of LoopRegions need to be unique inside the CFG (validation checks that). So far, we didn't have problems. However, with "no simplify before stree", we are getting in places where this is an issue. This commit deploys a simple fix to ensure unique names of LoopRegions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings back a couple of stree -> SDFG fixes from the NASA working branch #2364, which accumulated a bunch of changes last month. In particular, this PR contains
Support for collecting scalar memlets bleeds out into
sdfg.pyandstate.py. All changes there (outside the schedule tree world) are fully backwards compatible.problematic stree -> sdfg transformation before fix number 2