Added new framework APPy, and its implementation for one benchmark go_fast #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnick83
approved these changes
Feb 3, 2025
Contributor
alexnick83
left a comment
alexnick83
left a comment
There was a problem hiding this comment.
Looks good. I see that you are using pytorch to get the data on the GPU. This is not an issue since there is interoperability between torch and cupy, but we may need to update how data are validated.
Contributor
Author
Ah I see, thanks for taking a look and pointing that out. I'll fix that and send another PR, either by just using CuPy arrays as input/output, or updating the validation code to also allow pytorch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alex, Could you review when you get a chance? Thanks a lot! @alexnick83
For now I've just added the APPy code for one benchmark. Will try to add more if the PR works well.