-
Notifications
You must be signed in to change notification settings - Fork 354
Update Note in LGPL-x.y-only #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
xsuchy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
I would merge this, but CI is failing with: |
|
Just FYI - I improved the error messages in the publisher to point out exactly which warnings are not being ignored and @swinslow has improved the input to the expected warnings. Once I publish the next release and update the CI - these will be easier to diagnose. |
|
@goneall would you mind releasing the new version of LicenseListPublisher? I wanted to build it locally, but I got errors that are beyond my knowledge. And I would like to unblock this PR. |
This is on my radar as well. I'd like to merge in spdx/LicenseListPublisher#216 before the next release - @xsuchy can you confirm it is OK to switch to the JSON warnings format? Once confirmed, I'll merge that in, update the dependencies and roll out a new release. |
I do not have any automation attached to this. And I, as a human, can read JSON too :) So fine with me. |
|
+1 from my side as well to merge spdx/LicenseListPublisher#216, I just replied there also. |
|
I forgot I need to update #2772 first to align with the changes in spdx/LicenseListPublisher#216. Ugh, sorry. Will try to do so tomorrow on my way back from the conference... |
|
Still errors with: The problematic part is |
|
These are issues introduced with the latest release of the licenselistpublisher. If the only warning is a duplicate ID of a single license being modified, you can safely merge. It will not cause any subsequent errors after merging. We could go back to a previous version of the publisher, but we would need to update the warnings file back to the text format. I'll work on a new publisher release once I'm back from travels in about a week |
fixes #2705
Signed-off-by: Jilayne Lovejoy