New License: UnRAR

[jlovejoy]

fixes #2749

Signed-off-by: Jilayne Lovejoy

will need to add line breaks after PR is made

[xsuchy]

The failure of check is strange. It fails in titleText tag that should be ignore for matching purposes. @goneall do you have idea?
Otherwise LGTM, but I would rather see the check cleared first.

[goneall]

The failure of check is strange. It fails in titleText tag that should be ignore for matching purposes. @goneall do you have idea? Otherwise LGTM, but I would rather see the check cleared first.

Agree that this is a strange failure. titleText is treated as optional, not as an alternative or variable, so the text inside the titleText tags do need to match if the title is present. From a visual comparison, they look like they do match. I can look into it in more detail and see if I can find the cause.

[goneall]

Looks like a bug in the SPDX Java library compare routines.

Somehow it is loosing one of the *'s from the XML file while doing the compare. I'll continue investigating.

[goneall]

I've narrowed down the issue. The text file lines which start with \s* are interpreted as comment characters and are stripped out. The XML and template files are not stripping this out because there is no newline generated. This should be fixable by adding <br/> or

...

` between the title lines. However, when I tried that, it did not put in the new lines.

BTW - This will also affect formatting since the title shows up as a single line currently.

[goneall]

OK - verified that if you update the XML for the title to the following, it will work:

         <titleText>
            ****** ***** ****** UnRAR - free utility for RAR archives
            <br/>
            ** ** ** ** ** ** ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           <br/>
            ****** ******* ****** License for use and distribution of
           <br/>
            ** ** ** ** ** ** ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ **
           <br/>
            ** ** ** ** ** FREE portable version ~~~~~~~~~~~~~~~~~~~~~
         </titleText>