Rename ContactPointRelationshipType -> ContactType; Revise hasContactPoint desc - #1271
Open
bact wants to merge 5 commits into
Open
Rename ContactPointRelationshipType -> ContactType; Revise hasContactPoint desc#1271bact wants to merge 5 commits into
bact wants to merge 5 commits into
Conversation
…onship - Clarify description of hasContactPoint - "security" type of contact is not exist (what exist is "securityVulnerability") - Make it more clear that the contact type is in the `to` element - Rename `ContactPointRelationshipType` to `ContactType` - Remove ambiguity whether it is a type of `ContactPointRelationship` (it is not) - Matched `contactType` property - Shorter - See `LifecycleScopeType` (for `LifecycleScopedRelationship`) for example - Update the `ContactType` description - Remove "securityVulnerability" example that just repeating the entry description. - Make it more explicit that this is an enum (not the property) Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
bact
added
Profile:Core
bact
changed the title
bact
changed the title
Collaborator
Author
|
The name |
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
may = persmission can = possibility / capability Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
kestewart
reviewed
Jun 2, 2026
| ## Summary | ||
|
|
||
| Identifies the nature of the contactPointRelationship. | ||
| Identifies the nature of the `ContactPointRelationship`. |
Contributor
There was a problem hiding this comment.
Should this be ContactPoint?
Collaborator
Author
There was a problem hiding this comment.
As we still have ContactPointRelationship as a subclass of Relationship, this -Relationship suffixed naming is consistent with classes like /Core/LifecycleScopedRelationship and /Security/VulnAssessmentRelationship.
Member
|
@bact - if you could resolve the conflicts, we can merge in. On a call with @kestewart and Kate's OK with the change. |
goneall
approved these changes
Aug 28, 2026
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Collaborator
Author
|
Conflicts resolved. |
Member
|
@kestewart - ready to merge - if you could do a second review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContactPointRelationshipTypetoContactTypeContactPointRelationship(it is not)contactTypepropertyLifecycleScopeType(forLifecycleScopedRelationship) exampleContactTypedescriptiontoelement