feat: quick button to make mcp server public#2042
feat: quick button to make mcp server public#2042aditya-mitra wants to merge 1 commit intospeakeasy-api:mainfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
@aditya-mitra is attempting to deploy a commit to the Speakeasy Team on Vercel. A member of the Team first needs to authorize it. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| const handleMakePublic = () => | ||
| updateToolsetMutation.mutate( | ||
| { | ||
| request: { | ||
| slug: toolset.slug, | ||
| updateToolsetRequestBody: { mcpIsPublic: true }, | ||
| }, | ||
| }, | ||
| { | ||
| onSuccess: () => { | ||
| invalidateAllToolset(queryClient); | ||
| toast.success("Server is now public."); | ||
| }, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
🚩 Missing specific error handling for plan-limited public server quota
The new handleMakePublic in MCPOverviewTab (line 410-424) relies solely on the global mutation onError handler (client/dashboard/src/contexts/Sdk.tsx:42-44) which shows a generic "Request failed" toast. In contrast, MCPSettingsTab (lines 1048-1056) specifically checks for "maximum number of public MCP servers for your account type" and opens a FeatureRequestModal prompting an upgrade. Users hitting the plan limit via the new Overview tab button will see a less informative generic error instead of the upgrade flow. This isn't a correctness bug (the error is still surfaced), but it's a UX gap that may confuse users on the base plan.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Adds a quick button beside the warning to make the server public