fix: clean up worker and run state on daemon shutdown#24
Merged
Conversation
shutdown_all now updates worker DB status to stopped and cancels active runs, preventing orphaned workers from being respawned on next daemon start. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shutdown_allnow marks workers asstoppedand cancels active runs in the DB before exiting, matching whatstop_workeralready does for individual workers.Daemon shutdown now cleans up worker and run state
Previously, when the granary daemon shut down (via
granary daemon stop, signals, or any other reason), workers were signalled to stop but their database status was never updated. This left workers permanently marked asrunningin the global database with their active runs also stuck inrunningstate.On next daemon start,
restore_workerswould find these stale "running" workers and attempt to respawn them — potentially picking up orphaned runs from completely unrelated workspaces. Manually stopping individual workers worked correctly becausestop_workerproperly updated the DB, but the bulkshutdown_allpath (used on daemon exit) skipped this cleanup entirely.shutdown_allnow mirrors the same cleanup thatstop_workerdoes: after signalling and waiting for workers to finish, it marks each worker asstoppedand cancels any active runs in the database.✻ Clauded...