Skip to content

feat: add PyPI trusted publishing support #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielkov merged 1 commit into from
Feb 4, 2026
Merged

feat: add PyPI trusted publishing support #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions schemas/workflow.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,12 +326,17 @@
"additionalProperties": false,
"properties": {
"token": {
"description": "PyPI API token for token-based authentication. Not required if using trusted publishing.",
"type": "string"
},
"useTrustedPublishing": {
"description": "Use OIDC trusted publishing instead of token-based authentication. See https://docs.pypi.org/trusted-publishers/",
"type": [
"null",
"boolean"
]
}
},
"required": [
"token"
],
"type": "object"
},
"WorkflowRubyGems": {
Expand Down
24 changes: 17 additions & 7 deletions workflow/target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,9 @@ type NPM struct {
}

type PyPi struct {
_ struct{} `additionalProperties:"false"`
Token string `yaml:"token" required:"true"`
_ struct{} `additionalProperties:"false"`
Token string `yaml:"token,omitempty" description:"PyPI API token for token-based authentication. Not required if using trusted publishing."`
UseTrustedPublishing *bool `yaml:"useTrustedPublishing,omitempty" description:"Use OIDC trusted publishing instead of token-based authentication. See https://docs.pypi.org/trusted-publishers/"`
}

type Packagist struct {
Expand Down Expand Up @@ -195,9 +196,15 @@ func (p Publishing) Validate(target string) error {
}
}
case "python":
if p.PyPi != nil && p.PyPi.Token != "" {
if err := validateSecret(p.PyPi.Token); err != nil {
return fmt.Errorf("failed to validate pypi token: %w", err)
if p.PyPi != nil {
usesTrustedPublishing := p.PyPi.UseTrustedPublishing != nil && *p.PyPi.UseTrustedPublishing
if usesTrustedPublishing && p.PyPi.Token != "" {
return fmt.Errorf("pypi token should not be provided when using trusted publishing")
}
if !usesTrustedPublishing && p.PyPi.Token != "" {
if err := validateSecret(p.PyPi.Token); err != nil {
return fmt.Errorf("failed to validate pypi token: %w", err)
}
}
}
case "php":
Expand Down Expand Up @@ -262,8 +269,11 @@ func (p Publishing) IsPublished(target string) bool {
return true
}
case "python":
if p.PyPi != nil && p.PyPi.Token != "" {
return true
if p.PyPi != nil {
usesTrustedPublishing := p.PyPi.UseTrustedPublishing != nil && *p.PyPi.UseTrustedPublishing
if usesTrustedPublishing || p.PyPi.Token != "" {
return true
}
}
case "php":
if p.Packagist != nil {
Expand Down