Skip to content

fix: full virtual fs #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adaam2 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: full virtual fs #79

adaam2 wants to merge 2 commits into from

Conversation

@adaam2
Copy link
Member

@adaam2 adaam2 commented May 16, 2025 •
edited
Loading

The codebase still uses filepath.Abs which internally calls os.getwd which is problematic in a virtual filesystem

This PR changes the FS API slightly so that you also have to pass in a custom Abs(path) implementation

adaam2
adaam2 commented May 16, 2025
View reviewed changes
workspace/workspace.go
AllowOutside bool // Allow searching outside the workspace
Recursive bool // Recursively search for the workspace in parent directories
FS FS // An optional filesystem to use
FS fs.FS // An optional filesystem to use
Copy link
Member Author

@adaam2 adaam2 May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make non optional

@adaam2 adaam2 requested a review from ThomasRooney May 16, 2025 10:59
@ThomasRooney ThomasRooney self-assigned this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomasRooney ThomasRooney ThomasRooney approved these changes

Assignees

@ThomasRooney ThomasRooney

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adaam2 @ThomasRooney