Skip to content

feat: php publish fix#211

Merged
bflad merged 12 commits intomainfrom
feat/php_publish_fix
Feb 17, 2025
Merged

feat: php publish fix#211
bflad merged 12 commits intomainfrom
feat/php_publish_fix

Conversation

@idbentley
Copy link
Copy Markdown
Contributor

Update the php publish to checkout the repo, and read the packagename from the composer.json file. Pass the repository information, but no packageName.

@idbentley idbentley requested a review from a team as a code owner February 17, 2025 15:25
Copy link
Copy Markdown
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I did not review the other changes)

idbentley and others added 2 commits February 17, 2025 10:31
Co-authored-by: Brian Flad <bflad417@gmail.com>
Co-authored-by: Brian Flad <bflad417@gmail.com>
@idbentley
Copy link
Copy Markdown
Contributor Author

idbentley commented Feb 17, 2025

This fixes both Clerk issues and StackOne's regression with this companion commit: speakeasy-api/packagist-update@173b1d7

steps:
- name: Tune GitHub-hosted runner network
uses: smorimoto/tune-github-hosted-runner-network@v1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @bflad 's comments above.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot From 2025-02-17 13-06-08

Copy link
Copy Markdown
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@bflad bflad merged commit 8ab8fef into main Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants