Skip to content

Comments

fix: Bug fix for custom security scheme alongside other security options, client credentials hook#1361

Merged
kanwardeep007 merged 6 commits intomainfrom
fix-x-ndjson-warning-in-cli
Apr 2, 2025
Merged

fix: Bug fix for custom security scheme alongside other security options, client credentials hook#1361
kanwardeep007 merged 6 commits intomainfrom
fix-x-ndjson-warning-in-cli

Conversation

@kanwardeep007
Copy link
Contributor

@kanwardeep007 kanwardeep007 commented Apr 1, 2025

Updated the title after looking at the commits since 564.5 in openapi generator -

  • f3411ce - Add ability to pass language target for validation (#2470) (commit by @kanwardeep007)
  • 292aa49 - java - simplify client credentials hook, oauth2-password multi-option support preparation GEN-1261 (#2465) (commit by @davidmoten)
  • b963292 - custom security scheme alongside other security options TypescriptV2 (#2461) (commit by @2ynn)

This changes in this PR is linked to https://github.com/speakeasy-api/openapi-generation/pull/2470

New Logic
We now pass the target language information from the speakeasy cli command when possible and use it to validate the openapi document. The validation step contains actual validation of the openapi doc and generating the SDK with the target language to see if there are any errors

Before this PR
If we run speakeasy quickstart for a client openapi spec which contains jsonl or x-ndjson response we get the following output

jsonl-errors-cli

After this PR

jsonl-without-errors-cli

Screen recording showing the difference in studio
First quickstart command shows how the studio looks currently
Second quickstart command shows how the studio looks after this change

screen.recording.showing.the.difference.in.studio.mov

@kanwardeep007 kanwardeep007 force-pushed the fix-x-ndjson-warning-in-cli branch from afa2e5e to b423de6 Compare April 1, 2025 17:09
@kanwardeep007 kanwardeep007 marked this pull request as ready for review April 1, 2025 17:24
@kanwardeep007
Copy link
Contributor Author

kanwardeep007 commented Apr 1, 2025

The lint error in CICD comes because the openapi-generation version hasn't been updated which contains the new arguments. I want to make sure people are happy with this PR before I merge changes in the openapi-generation (openapi generation pr here)

Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me

@kanwardeep007 kanwardeep007 changed the title chore: Add ability to pass language target for validation fix: Bug fix for custom security scheme alongside other security options, client credentials hook Apr 2, 2025
@kanwardeep007 kanwardeep007 merged commit 2cac600 into main Apr 2, 2025
4 checks passed
@kanwardeep007 kanwardeep007 deleted the fix-x-ndjson-warning-in-cli branch April 2, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants