fix: Bug fix for custom security scheme alongside other security options, client credentials hook#1361
Merged
kanwardeep007 merged 6 commits intomainfrom Apr 2, 2025
Merged
Conversation
afa2e5e to
b423de6
Compare
Contributor
Author
|
The lint error in CICD comes because the openapi-generation version hasn't been updated which contains the new arguments. I want to make sure people are happy with this PR before I merge changes in the openapi-generation (openapi generation pr here) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the title after looking at the commits since 564.5 in openapi generator -
This changes in this PR is linked to https://github.com/speakeasy-api/openapi-generation/pull/2470
New Logic
We now pass the target language information from the speakeasy cli command when possible and use it to validate the openapi document. The validation step contains actual validation of the openapi doc and generating the SDK with the target language to see if there are any errors
Before this PR
If we run speakeasy quickstart for a client openapi spec which contains jsonl or x-ndjson response we get the following output
After this PR
Screen recording showing the difference in studio
First quickstart command shows how the studio looks currently
Second quickstart command shows how the studio looks after this change
screen.recording.showing.the.difference.in.studio.mov