Skip to content

add py.typed marker for typing#1947

Open
fridex wants to merge 1 commit into
spec-first:mainfrom
fridex:py.typed
Open

add py.typed marker for typing#1947
fridex wants to merge 1 commit into
spec-first:mainfrom
fridex:py.typed

Conversation

@fridex

@fridex fridex commented Jul 10, 2024

Copy link
Copy Markdown

Signed-off-by: Fridolin Pokorny <fridolin.pokorny@gmail.com>
@RobbeSneyders

Copy link
Copy Markdown
Member

Thanks @fridex!

There were some doubts previously if this is the best way to go if our types are not perfect, see this comment. Do you have a view on that?

@fridex

fridex commented Oct 24, 2024

Copy link
Copy Markdown
Author

There were some doubts previously if this is the best way to go if our types are not perfect, see this comment. Do you have a view on that?

I've tried mypy on codebase and, sadly, it does not seem to be ready for typing.

@RobbeSneyders

Copy link
Copy Markdown
Member

Can you expand a bit?

Note that we are running mypy on every commit already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants