fix: parse charset when Content-Type has whitespace after ';' - #2130
Open
jaideeppyne wants to merge 1 commit into
Open
fix: parse charset when Content-Type has whitespace after ';'#2130jaideeppyne wants to merge 1 commit into
jaideeppyne wants to merge 1 commit into
Conversation
split_content_type() looked for the charset parameter with
str.startswith('charset='), but iterated over the raw semicolon-split
parts without trimming the optional whitespace allowed by RFC 7231.
As a result the common 'application/json; charset=utf-8' form (space
after the separator) failed to detect the encoding and callers silently
fell back to utf-8, mis-decoding request/response bodies sent in another
charset. Strip surrounding whitespace from the media type and each
parameter before matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
split_content_type()failed to pick up the charset when the Content-Type header has a space after the;, e.g.application/json; charset=utf-8. It matched parameters withstartswith("charset=")on the raw semicolon-split parts, without trimming the optional whitespace that RFC 7231 allows. So the common spaced form returnedencoding=None, and the request/response validators silently fell back to utf-8 and mis-decoded bodies sent in another charset.Reproduction on current
main:Changes proposed in this pull request:
split_content_typebefore matching the charset parameter.