fix(w3c): match CSS selectors used in base.css#5160
Conversation
daniel-montalvo
changed the title
sidvishnoi
changed the title
There was a problem hiding this comment.
Pull request overview
This PR aligns the W3C SoTD and header logic with the CSS class selectors used by W3C’s base.css for revised Recommendations, specifically around distinguishing candidate vs proposed additions/corrections.
Changes:
- Update SoTD logic to detect candidate additions/corrections using
.addition:not(.proposed)/.correction:not(.proposed). - Update W3C header validation logic to use
.addition.proposed/.correction.proposed(and exclude.proposedwhen checking for non-proposed revisions).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/w3c/templates/sotd.js | Fixes revision-detection selectors to distinguish proposed vs candidate changes. |
| src/w3c/headers.js | Updates revision-related selectors for updatable REC validations to match the class conventions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
See what co-pilot said
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Unfortunately copilot won’t do cross org fixes, but I can get it to suggest changes/fixes if that helps. @copilot can you review again and suggest fixes inline? |
daniel-montalvo
dismissed
marcoscaceres’s stale review
I created tests yesterday and pushed them in c752869
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
marcoscaceres
force-pushed
the
fix-basecss-classes
branch
from
257df0c to
ec17158
Compare
Hi @marcoscaceres @sideshowbarker can you take a look at this one?
It contains a couple more mismatched selectors for revised recommendations that I forgot about in #5149