Skip to content

feat(core/dfn-index): data-noindex for external terms#5250

Open
marcoscaceres wants to merge 2 commits into
mainfrom
feat/4895-data-noindex
Open

feat(core/dfn-index): data-noindex for external terms#5250
marcoscaceres wants to merge 2 commits into
mainfrom
feat/4895-data-noindex

Conversation

@marcoscaceres
Copy link
Copy Markdown
Contributor

Closes #4895

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a granular opt-out (data-noindex) so authors can prevent specific external data-cite links from being listed under “Terms defined by reference” in the dfn index (per #4895).

Changes:

  • Skip a[data-cite][data-noindex] entries when collecting the external terms index.
  • Strip data-noindex during export cleanup (similar to other ReSpec-only attributes).
  • Add a spec test for the new exclusion behavior and add French l10n strings for the dfn index headings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/core/dfn-index.js Implements data-noindex exclusion in external term collection; adds export cleanup; adds fr l10n strings.
tests/spec/core/dfn-index-spec.js Adds coverage ensuring data-noindex terms are omitted from the external index.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/spec/core/dfn-index-spec.js
Address Copilot feedback: the test now asserts that the external index
section exists and contains the expected 'Event interface' term, so the
absence assertion for the excluded term cannot vacuously pass when
the index is empty.
@marcoscaceres
Copy link
Copy Markdown
Contributor Author

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

@marcoscaceres
Copy link
Copy Markdown
Contributor Author

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

Yes, all feedback has been addressed. The single review comment (about the test passing vacuously on an empty index) was fixed in 904170d. The test now has three positive assertions alongside the negative one:

  1. expect(externalIndex).toBeTruthy() — index section exists
  2. expect(terms.length).toBeGreaterThan(0) — at least one term collected
  3. expect(terms).toContain("Event interface") — a known term is present

There are no other outstanding review items.

@marcoscaceres marcoscaceres marked this pull request as ready for review May 9, 2026 02:40
@marcoscaceres marcoscaceres requested review from sidvishnoi and removed request for sidvishnoi May 9, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide an opt-out of the "Terms defined by reference" section

3 participants