feat(core/dfn-index): data-noindex for external terms#5250
feat(core/dfn-index): data-noindex for external terms#5250marcoscaceres wants to merge 2 commits into
Conversation
…erms index Closes #4895
There was a problem hiding this comment.
Pull request overview
Adds a granular opt-out (data-noindex) so authors can prevent specific external data-cite links from being listed under “Terms defined by reference” in the dfn index (per #4895).
Changes:
- Skip
a[data-cite][data-noindex]entries when collecting the external terms index. - Strip
data-noindexduring export cleanup (similar to other ReSpec-only attributes). - Add a spec test for the new exclusion behavior and add French l10n strings for the dfn index headings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/core/dfn-index.js |
Implements data-noindex exclusion in external term collection; adds export cleanup; adds fr l10n strings. |
tests/spec/core/dfn-index-spec.js |
Adds coverage ensuring data-noindex terms are omitted from the external index. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address Copilot feedback: the test now asserts that the external index section exists and contains the expected 'Event interface' term, so the absence assertion for the excluded term cannot vacuously pass when the index is empty.
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
Yes, all feedback has been addressed. The single review comment (about the test passing vacuously on an empty index) was fixed in
There are no other outstanding review items. |
Closes #4895