Skip to content

Guard caniuse table rendering against missing .head dl element #5374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brian-soltani wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −2
Open

Guard caniuse table rendering against missing .head dl element #5374

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87d441a
Guard caniuse table rendering against missing .head dl element
brian-soltani Jul 29, 2026
0ee5ef7
Merge branch 'main' into patch-1
marcoscaceres Aug 21, 2026
62b29a4
Potential fix for pull request finding
marcoscaceres Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/core/caniuse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ export async function run(conf) {
// @ts-expect-error -- options is the normalized object form
const featureURL = new URL(options.feature, "https://caniuse.com/").href;
const headDlElem = document.querySelector(".head dl");
if (!headDlElem) {
const msg = `Can't render caniuse browser support table: no ".head dl" element was found.`;
showWarning(msg, name);
return;
Comment on lines +89 to +92
}
// @ts-expect-error -- options and conf.caniuse are the normalized object form
const contentPromise = fetchStats(conf.caniuse)
// @ts-expect-error -- options is object form
Expand All @@ -99,15 +104,15 @@ export async function run(conf) {
placeholder: "Fetching data from caniuse.com...",
}}
</dd>`;
headDlElem?.append(...definitionPair.childNodes);
headDlElem.append(...definitionPair.childNodes);
await contentPromise;
// @ts-expect-error -- options is the normalized object form
pub("amend-user-config", { caniuse: options.feature });
// @ts-expect-error -- options is the normalized object form
if (options.removeOnSave) {
// Will remove the browser support cells.
headDlElem
?.querySelectorAll(".caniuse-browser")
.querySelectorAll(".caniuse-browser")
.forEach(elem => elem.classList.add("removeOnSave"));
sub(
"beforesave",
Expand Down
Loading