-
Notifications
You must be signed in to change notification settings - Fork 41
Create a new setup page #6671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Create a new setup page #6671
Conversation
|
Any INSERT INTO spuserpolicy (id, resource, action, collection_id, specifyuser_id) VALUES (1, '%', '%', null, 1); |
|
NOTES:
|
63728c3 to
31211cc
Compare
Triggered by 31211cc on branch refs/heads/issue-2931-1
Triggered by 724c24b on branch refs/heads/issue-2931-1
|
@grantfitzsimmons @CarolineDenis This pr should be ready to test again 👍 As for the progress bar, I want to see if I can speed up schema config creation more in a separate PR. That should make it easier to estimate how long the set up process takes. |
grantfitzsimmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Use a blank DB to test this PR.
New DB was created!
- Fill out the setup forms
- Make sure the forms look good in light mode and dark mode (It uses your system settings.)
- You can only progress to the next form if you filled out all required fields.
- Make sure your choices are shown in the Overview sidebar.
- Make sure you can submit at the end.
Some database restrictions (e.g. max field length) are not accounted for, say for instance when you enter more text than is able to fit in a field (e.g. institution.Name)

- Make sure you can log into the database.
There is still a reported schema mismatch (it expects 6.8.03, returning 7)

- Make sure the schema config defaults were applied correctly.
- Make sure default picklists were created correctly.
- Make sure prep types were created correctly.
- Make sure all tree viewer pages load.
When creating a 'Herbarium' collection, my Taxon tree looks like this:
See Geography as well:
Same story for Storage...
- Local testing:
- Use an empty DB again (restore it or use a different one).
- Stop the specify worker and try to start the setup. You should get a clear error on the frontend.
It just pauses on loading Institution?
- [X] Make sure API endpoints work. Look at the stetup_tool section in http://localhost/documentation/api/operations/all/ for more information. You should be able to manually set up a blank database by creating these resources in order. - [X] `setup_tool/institution/create` - [X] `setup_tool/division/create` - [X] `setup_tool/discipline/create` - [X] `setup_tool/collection/create` - [X] `setup_tool/specifyuser/create`
|
@grantfitzsimmons thanks for the review!
Fixed for institution name and password 👍
Once the tree PR is merged I can create a PR to properly create the trees. EDIT: #7593 <- to be addressed once the tree creation PR is merged
Hm I'm getting an error (it's not descriptive, though). I might need to look at your set up to see if the check isn't working or if the error isn't being reported.
EDIT: Hopefully addressed by my new changes |
| 'insert into specifyuser_spprincipal(specifyuserid, spprincipalid) values (%s, %s)', | ||
| [user.id, gp.id] | ||
| ) | ||
| # TODO: UNCOMMENT THIS. Commented specifically for testing PR https://github.com/specify/specify7/pull/6671 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
| WHERE Name = 'Administrator' | ||
| ) | ||
| """, [self.id]) | ||
| # TODO: UNCOMMENT THIS. Commented specifically for testing PR https://github.com/specify/specify7/pull/6671 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
| # Create picklists | ||
| create_default_picklists(new_collection, discipline.type) | ||
| # Create Collection Object Type | ||
| # TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note





Fixes #2931
Fixes #4832
Fixes #6210
Adds an initial set up page for configuring your database much like the Spwizard for Specify 6.
TODO:
specifyuser_spprincipaltable needs to exist before the setup process works on a new sp7 database. It also looks like the admin user isn't actually a proper admin.Future TODO:
Checklist
self-explanatory (or properly documented)
Testing instructions
setup_tool/institution/createsetup_tool/division/createsetup_tool/discipline/createsetup_tool/collection/createsetup_tool/specifyuser/create