-
Notifications
You must be signed in to change notification settings - Fork 41
Make attachment downloads asynchronous (through notification) #6892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alesan99
wants to merge
43
commits into
main
Choose a base branch
from
issue-6521-async
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by bce323c on branch refs/heads/issue-6521
Fix missing parameter
Triggered by 28d620c on branch refs/heads/issue-6521
Remove instances of camelcase in backend download code Remove print statements
Triggered by e82ffbc on branch refs/heads/issue-6521
Triggered by 3aa43ac on branch refs/heads/issue-6521
Triggered by 5ff89c6 on branch refs/heads/issue-6521
Triggered by 6d3137e on branch refs/heads/issue-6521
Triggered by 954ce9e on branch refs/heads/issue-6521
10 tasks
…into issue-6521-async
Triggered by 993178d on branch refs/heads/issue-6521-async
Contributor
Author
|
NOTE: #6625 now solves #6947 . That means this PR is only good for making attachment downloads use notifications. Benefits:
Downsides:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6947
Extension of #6625
Clicking Download All on an attachment gallery will give you a download link in a notification once the download is ready.
Should fix the 504 Gateway Time-out error on large downloads.
This allows for downloads that take over a minute to download, given that the server is configured to have enough storage to store the file.
Checklist
self-explanatory (or properly documented)
Testing instructions