Skip to content

Conversation

@alesan99
Copy link
Contributor

@alesan99 alesan99 commented Jul 2, 2025

Fixes #6947
Extension of #6625

Clicking Download All on an attachment gallery will give you a download link in a notification once the download is ready.

Should fix the 504 Gateway Time-out error on large downloads.
This allows for downloads that take over a minute to download, given that the server is configured to have enough storage to store the file.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Click on the attachment gallery button on a record set with attachments
    image
  • Click "Download All"
  • Verify that a "Attachment Archive Being Created" dialog appears after clicking download all.
  • See that a notification appears with your download.
  • Verify the notification is deleted after you click download (The file from the backend is deleted after you download it).
  • Verify the download worked.
  • Verify you still can't download all attachments in "browse in forms" if you haven't loaded in all the attachments.
  • The Download All button should still work in general.
  • Dev testing note:
    • Deleting a notification also deletes the file. You can verify this PR is working correctly by checking the zip files in DEPOSITORY_DIR

alesan99 added 28 commits June 11, 2025 12:43
Triggered by bce323c on branch refs/heads/issue-6521
Fix missing parameter
Triggered by 28d620c on branch refs/heads/issue-6521
Remove instances of camelcase in backend download code
Remove print statements
Triggered by e82ffbc on branch refs/heads/issue-6521
Triggered by 3aa43ac on branch refs/heads/issue-6521
Triggered by 5ff89c6 on branch refs/heads/issue-6521
Triggered by 6d3137e on branch refs/heads/issue-6521
Triggered by 954ce9e on branch refs/heads/issue-6521
@alesan99 alesan99 marked this pull request as draft July 2, 2025 17:43
@alesan99 alesan99 marked this pull request as ready for review July 8, 2025 18:04
@alesan99
Copy link
Contributor Author

alesan99 commented Jul 9, 2025

NOTE: #6625 now solves #6947 . That means this PR is only good for making attachment downloads use notifications.

Benefits:

  • Allows the user to navigate away from the download while the zip file is being prepared.
  • Adds functionality for notifications to delete their associated files. Useful for cleaning up csv exports.

Downsides:

@alesan99 alesan99 added the todo:discuss Needs Discussion label Jul 9, 2025
Base automatically changed from issue-6521 to main September 29, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

todo:discuss Needs Discussion

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

2 participants