Skip to content

Conversation

@alesan99
Copy link
Contributor

@alesan99 alesan99 commented Jul 14, 2025

Fixes #6078

image
  • TODO:
  • Remove existing attachments from row.
  • Delete attachments when a row is deleted. (Maybe do this on the backend? Simple, but could be very inefficient to read entire spreadsheet to find out if an attachment is being referenced.)
  • Edit attachment order (Maybe a future PR?)
  • Switch attachment in attachment viewer
  • Save the dataset once an attachment has been added (Prompt user to save before uploading an attachment?).
  • Cleanup (Split up big files, simplify arguments being passed into functions)

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Go to Workbench -> Import Attachments
  • Upload multiple attachments.
  • Select an existing row and add a new attachment
  • Make sure the dataset was saved once the attachment was uploaded.
  • Select an existing row and add multiple new attachments.
  • Add an attachment to a new row

Temporarily disable dataset loading
Remove dataset testing stuff
Triggered by b8d1889 on branch refs/heads/issue-6075
Triggered by bf9a7eb on branch refs/heads/issue-6075
Triggered by fd2c42c on branch refs/heads/issue-6075
Triggered by d93a3ac on branch refs/heads/issue-6075
Triggered by af95077 on branch refs/heads/issue-6075
Triggered by e7f5281 on branch refs/heads/issue-6075
Triggered by 7af5f3e on branch refs/heads/issue-6075
@alesan99 alesan99 changed the base branch from issue-6600 to issue-7108 August 20, 2025 16:30
Base automatically changed from issue-7108 to issue-6075 August 20, 2025 19:25
Base automatically changed from issue-6075 to main August 20, 2025 21:30
Triggered by 8a9b266 on branch refs/heads/issue-6078
Triggered by 4ce8d72 on branch refs/heads/issue-6078
Triggered by 2998853 on branch refs/heads/issue-6078
Triggered by bba0eb7 on branch refs/heads/issue-6078
Triggered by 24ef417 on branch refs/heads/issue-6078
Triggered by 27201ec on branch refs/heads/issue-6078
Fix adding attachment to the first row.
Fix attachment preview slider
Triggered by e154489 on branch refs/heads/issue-6078
@alesan99
Copy link
Contributor Author

  • TODO:
  • Remove existing attachments from row.
  • Delete attachments when a row is deleted. (Maybe do this on the backend? Simple, but could be very inefficient to read entire spreadsheet to find out if an attachment is being referenced.)
  • Edit attachment order (Maybe a future PR?)
  • Switch attachment in attachment viewer
  • Save the dataset once an attachment has been added (Prompt user to save before uploading an attachment?).
  • Cleanup (Split up big files, simplify arguments being passed into functions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Add attachments to rows in existing workbench data sets. (WB Attachments V2)

2 participants