Skip to content

Conversation

@alesan99
Copy link
Contributor

@alesan99 alesan99 commented Sep 15, 2025

Fixes #7419

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Create a regular WorkBench Data Set.
  • No errors when viewing or clicking around the spreadsheet.
  • Create a data set with "Import Attachments.
  • No errors when viewing or clicking around the attachment data set. The attachment sidebar should also appear.

@alesan99 alesan99 marked this pull request as ready for review September 22, 2025 18:13
@alesan99 alesan99 requested review from a team September 22, 2025 18:18
Triggered by 79190ff on branch refs/heads/issue-7283
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • No errors when viewing or clicking around the spreadsheet.
  • No errors when viewing or clicking around the attachment data set. The attachment sidebar should also appear.

I'm getting this error in the console when opening an imported dataset that I don't get in main. I'm requesting changes in case this could cause problems but if it's not a big deal then I can approve.

Link to the dataset: https://ojsmnh20250910-issue-7283.test.specifysystems.org/specify/workbench/560

Error:
Screenshot 2025-09-23 094543

@github-project-automation github-project-automation bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Sep 23, 2025
@alesan99
Copy link
Contributor Author

Link to the dataset: https://ojsmnh20250910-issue-7283.test.specifysystems.org/specify/workbench/560

I could recreate it on your database on that dataset but not on my database, I'm not sure what conditions cause that exactly. The error looks like it might be caused by this PR so I'm going to look into it once I have time.

@CarolineDenis CarolineDenis modified the milestones: 7.12.0, 7.13.0 Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Dev Attention Needed

Development

Successfully merging this pull request may close these issues.

WB Attachments: Possible crash if attachments column is missing

5 participants