-
Notifications
You must be signed in to change notification settings - Fork 41
Fix : Missing Catalog Number Placeholder for Inherited Values in Child COs #7539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Research, unrelated to PR: I checked out In
In
I tried quite a number of times to get inheritance to work on both, using the following as my {"catalogNumberInheritance": {"behavior": {"inheritance": true}}}Neither work. Not sure where it broke before. Will test this PR soon. |
88b98b7 to
338c531
Compare
…tly and prevent parser placeholder from overriding inherited value
b3e949c to
ae758c0
Compare
Triggered by ae758c0 on branch refs/heads/issue-7537
Triggered by 98c9ad5 on branch refs/heads/issue-7537
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify in the UI that adding a child CO to a COG with
"catalogNumberInheritance": {
"behavior": {
"inheritance": true
}}now shows the primary CO’s catalog number as a grayout placeholder that can be manually edited.
After adding the inheritance clause to the json file in app resources:
The new children of added to the COG are not properly inheriting the number form the primary number nor its being displayed as greyed out. and the auto numbering is still taking priority



Fixes #7537
This PR fixes Catalog Number Inheritance for Collection Object Groups so that new child COs no longer get auto-numbered when inheritance is enabled. The sibling API now resolves the primary catalog number using either a child_co_id or a cog_id, letting brand-new children (no id yet) inherit immediately. The COG “Add CO” dialog and catalog-number field component request the inherited value upfront and write it into the actual field value (not just a placeholder), while still allowing the user to edit it.
Checklist
self-explanatory (or properly documented)
Testing instructions
now shows the primary CO’s catalog number as a grayout placeholder that can be manually edited.