-
Notifications
You must be signed in to change notification settings - Fork 41
Discipline type picklist in migration #7584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make sure the
typefield is set to the new Discipline Types picklist - Make sure the picklist has all the discipline proper types
There is no discipline type picklist so the field is also not set to a picklist. I did also briefly get a migration error upon first load but it went away and I cannot reproduce it so I am not sure if it's a problem or not.
@emenslin Hm I tried a copy of your database locally and the picklist migration ran. I'm not sure what a happened. I did make changes to the code so hopefully it works now. EDIT: Once that PR is merged the migration should run. |
|
@specify/ux-testing with #7587 merged, this PR is ready to test again! 👍 |
Triggered by 55f5353 on branch refs/heads/issue-7582
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triggered by 811425b on branch refs/heads/issue-7582

Fixes #7582
Warning
This PR affects database migrations. See migration testing instructions.
⚠️
Adds a new discipline types picklist.
Checklist
self-explanatory (or properly documented)
Testing instructions
typefield is set to the new Discipline Types picklist0042_discipline_type_picklistmigration