Skip to content

Fix: Revert pr-#7391 #7597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarolineDenis wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −8
Open

Fix: Revert pr-#7391 #7597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions specifyweb/frontend/js_src/lib/components/PickLists/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,9 @@ export function PickListComboBox({

const isReadOnly = React.useContext(ReadOnlyContext);

const isSpecialByPrefix =
typeof pickListName === 'string' && pickListName.startsWith('_');
const isSpecialPicklist =
isDisabled || isSpecialByPrefix || pickList?.get?.('readOnly') === true;

return (
<>
{isSpecialPicklist ? (
{pickList?.get('readOnly') === true || isDisabled ? (
<Select
id={id}
value={value ?? ''}
Expand Down Expand Up @@ -201,7 +196,6 @@ export function PickListComboBox({
))}
</Select>
) : (
// Keep AutoComplete for all other picklists (type-to-search + add-new if permitted)
<AutoComplete<string>
aria-label={undefined}
disabled={isDisabled || isReadOnly}
Expand All @@ -216,7 +210,7 @@ export function PickListComboBox({
value={(currentValue?.title || value) ?? ''}
onChange={({ data }): void => updateValue(data)}
onCleared={(): void => updateValue('')}
onNewValue={handleAdd ? addNewValue : undefined}
onNewValue={addNewValue}
/>
)}
{typeof pendingNewValue === 'string' &&
Expand Down