Skip to content

Calculate closures correctly #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented May 16, 2025

get depths for sending so we can order by depth when receiving

Copy link

linear bot commented May 16, 2025

@adamhathcock adamhathcock force-pushed the adam/web-3379-c-sdk-needs-to-correctly-calculate-closures branch from 2258854 to 06d6d41 Compare May 17, 2025 12:20
@adamhathcock adamhathcock marked this pull request as ready for review May 19, 2025 08:40
@adamhathcock adamhathcock requested a review from JR-Morgan May 19, 2025 08:40
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 97.00855% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.16%. Comparing base (0f8752d) to head (5b92a85).

Files with missing lines Patch % Lines
...c/Speckle.Sdk/Serialisation/V2/Send/ClosureMath.cs 77.77% 4 Missing ⚠️
...ckle.Sdk/Serialisation/V2/Send/ObjectSerializer.cs 93.33% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #309       +/-   ##
===========================================
+ Coverage   63.78%   75.16%   +11.37%     
===========================================
  Files         267      288       +21     
  Lines       10673    11635      +962     
  Branches     1102     1114       +12     
===========================================
+ Hits         6808     8745     +1937     
+ Misses       3571     2513     -1058     
- Partials      294      377       +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adamhathcock adamhathcock enabled auto-merge (squash) May 22, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants