Skip to content

feat(automate): Add automate SDK #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 30, 2025

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented May 28, 2025

What I've done:

  • Copied the Automate SDK over from v2
  • Bumped it's dependencies
  • Changed target frameworks from netstandard2.0 -> netstandard2.0;net8.0
  • Minor tweaks for new rosylin analysers
  • Automate SDK now references Speckle.Objects <-- can explain a bit more about why, but no more kits, so not loosing much
  • Added ServiceRegistration for DI setup
  • Moved the static Initialize function from AutomateContext to AutomateContextFactory to allow for DI
  • Added some interfaces for DI ( IAutomateContextFactory, IAutomateContext, IAutomateRunner )
  • Copied Integration test project, and updated nunit -> xunit + shoudly to align with other tests we have
  • Note, the automate integration tests, like in v2, are skipped because of local server config... I hope to get around to updating them at somepoint.
  • Made the C# equivalent of feat(automate): attach application id-s to automate result cases specklepy#424 - this was done in this commit: 93eaa39

Also updated the template in this PR: specklesystems/SpeckleAutomateDotnetExample#29
Gave it a quick test this evening, looking good so far, but more testing to come.

TODO

  • Dotnet pack locally, check it looks good.
  • Fix CI failing, something about lock files

Copy link

linear bot commented May 28, 2025

@JR-Morgan JR-Morgan marked this pull request as draft May 28, 2025 22:36
Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 7.40741% with 25 lines in your changes missing coverage. Please review.

Project coverage is 75.04%. Comparing base (1039e75) to head (d8884ec).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...rialisation/V2/DeserializeProcessFactoryNoCache.cs 0.00% 25 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #313       +/-   ##
===========================================
+ Coverage   64.30%   75.04%   +10.74%     
===========================================
  Files         269      289       +20     
  Lines       10841    11660      +819     
  Branches     1112     1114        +2     
===========================================
+ Hits         6971     8750     +1779     
+ Misses       3574     2534     -1040     
- Partials      296      376       +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gjedlicska
gjedlicska previously approved these changes May 29, 2025
Copy link

@gjedlicska gjedlicska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JR-Morgan JR-Morgan marked this pull request as ready for review May 30, 2025 11:26
@JR-Morgan JR-Morgan merged commit b6be7a3 into dev May 30, 2025
4 checks passed
@JR-Morgan JR-Morgan deleted the jedd/cxpla-213-move-c-automate-sdk-to-the-new-sdk-repo branch May 30, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants