Skip to content

Fix: try adding object ids to render material proxies #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oguzhankoral merged 1 commit into from
Jun 26, 2025
Merged

Fix: try adding object ids to render material proxies #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions speckle_connector_3/src/sketchup_model/materials/material_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def unpack_materials(entities)

unless material.nil?
if render_material_proxies.has_key?(material.persistent_id.to_s)
render_material_proxies[material.persistent_id.to_s].add_object_id(entity.persistent_id.to_s)
render_material_proxies[material.persistent_id.to_s].try_add_object_id(entity.persistent_id.to_s)
else
convert_material_and_add_to_proxies(material, entity)
end
Expand All @@ -43,7 +43,7 @@ def unpack_materials(entities)
unless back_material.nil?
if render_material_proxies.has_key?(back_material.persistent_id.to_s)
render_material_proxies[back_material.persistent_id.to_s]
.add_object_id("#{entity.persistent_id.to_s}_back")
.try_add_object_id("#{entity.persistent_id.to_s}_back")
else
convert_material_and_add_to_proxies(back_material, entity, true)
end
Expand Down
8 changes: 5 additions & 3 deletions speckle_connector_3/src/speckle_objects/render_material_proxy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,11 @@ def initialize(sketchup_material, value, object_ids, application_id: nil)
end

# @param object_id [String] application id of the object to add into proxy list
def add_object_id(object_id)
object_ids.append(object_id)
self[:objects] = object_ids
def try_add_object_id(object_id)
unless object_ids.include?(object_id)
object_ids.append(object_id)
self[:objects] = object_ids
end
end
end
end
Expand Down