fix for relative path to .env #383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find I have to override this when running tests locally. Perhaps there is another way, or a failsafe alternative
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage 89.79% 89.79%
=======================================
Files 129 129
Lines 6852 6852
=======================================
Hits 6153 6153
Misses 699 699 ☔ View full report in Codecov by Sentry. |
|
ping @cdriesler for a functional test |
|
@jsdbroughton how are you running the tests? I had some issues with the former. But had no problem running the local tests today via VS code |
|
@jsdbroughton finally looked at this specifically - I do not need to override things either which makes me feel like this is a local environment issue. Which we might be able to protect against in the SDK but we also might be able to assert in the template/readme. Are you still experiencing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find I have to override this when running tests locally.
Perhaps there is another way, or a failsafe alternative