rename_all support on specta::specta macro#453
Merged
GitHub Actions / clippy
succeeded
May 5, 2026 in 0s
clippy
4 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 4 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.95.0 (59807616e 2026-04-14)
- cargo 1.95.0 (f2d3ce0bd 2026-03-21)
- clippy 0.1.95 (59807616e1 2026-04-14)
Annotations
Check warning on line 209 in specta/src/types.rs
github-actions / clippy
iterating on a map's values
warning: iterating on a map's values
--> specta/src/types.rs:206:21
|
206 | let mut v = self
| _____________________^
207 | | .types
208 | | .iter()
209 | | .filter_map(|(_, ndt)| ndt.as_ref())
| |________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#iter_kv_map
help: try
|
206 ~ let mut v = self
207 + .types.values().filter_map(|ndt| ndt.as_ref())
|
Check warning on line 163 in specta/src/types.rs
github-actions / clippy
iterating on a map's values
warning: iterating on a map's values
--> specta/src/types.rs:161:13
|
161 | / self.types
162 | | .iter()
163 | | .filter_map(|(_, ndt)| ndt.as_ref())
| |____________________________________________________^ help: try: `self.types.values().filter_map(|ndt| ndt.as_ref())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#iter_kv_map
Check warning on line 149 in specta/src/types.rs
github-actions / clippy
iterating on a map's values
warning: iterating on a map's values
--> specta/src/types.rs:147:13
|
147 | / self.types
148 | | .iter()
149 | | .filter_map(|(_, ndt)| ndt.as_ref())
| |____________________________________________________^ help: try: `self.types.values().filter_map(|ndt| ndt.as_ref())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#iter_kv_map
= note: `-W clippy::iter-kv-map` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::iter_kv_map)]`
Check warning on line 174 in specta/src/datatype/attributes.rs
github-actions / clippy
consider using `sort_by_key`
warning: consider using `sort_by_key`
--> specta/src/datatype/attributes.rs:174:9
|
174 | entries.sort_by(|(left, _), (right, _)| left.cmp(right));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_sort_by
= note: `-W clippy::unnecessary-sort-by` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_sort_by)]`
help: try
|
174 - entries.sort_by(|(left, _), (right, _)| left.cmp(right));
174 + entries.sort_by_key(|(left, _)| *left);
|
Loading