fix: 🐛 Reconciler error when updating AWSMCP publicCIDRs to empty list with endpointPrivateAccess: true and endpointPublicAccess: false #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Shen <[email protected]>
🌱 Fix test version string in order to use manifests from source files
…anagedMachinePools Co-authored-by: Cameron McAvoy <[email protected]>
📖 Clarify that the ROSA provider is currently for ROSA HCP clusters
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.33.0 to 0.36.0. - [Commits](golang/net@v0.33.0...v0.36.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/hack/tools/golang.org/x/net-0.36.0 🌱 Bump golang.org/x/net from 0.33.0 to 0.36.0 in /hack/tools
…wsmachines ✨ Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools
📖 Fix link to AWS ROSA documentation
…936-upstream ✨Add support for public-only networking
Signed-off-by: Richard Case <[email protected]>
…ease28 🌱 chore: update metadata for v2.8.x release series
Sets paused condition on AWSMachine Sets paused on AWSCluster Sets paused condition on AWSManagedMachinePool Sets paused condition for ROSAMachinePool Sets paused condition for ROSAControlPlane Sets paused condition on AWSManagedControlPlane Sets paused condition on EKSConfig Adds paused helper functions This change adds the paused helper utilities from upstream cluster api. It modifies them to not require v1beta2conditions. This is so we can use similar code until the conditions changes are out of beta.
…ndition ✨ Set Paused condition on reconciled resources status upon reconciliation being paused
Start with "unmanaged", or non-hosted control planes. Other controllers that can be optional, such as the EKS, ROSA, and MachinePool ones, are currently managed with feature flags. When they graudate, they should be controlled by the `--disable-controllers` flag.
Updates AWSManagedCluster with Paused Condition This change: - Updates the API for AWSManagedCluster to include a conditions field. - Sets `Paused` in the conditions if the controller is paused. Updates ROSACluster with Paused Condition This change: - Updates the API for ROSACluster to include a conditions field. - Sets `Paused` in the conditions if the controller is paused. Updates generated API types
✨ Support for BoostrapSelfManagedAddons flag for EKS cluster creation
…dcluster-paused ✨ Updates AWSManagedCluster, ROSACluster with Paused Condition
While kubernetes-sigs#5394 and kubernetes-sigs#5383 added support for patching a cluster/status in the cluster.x-k8s.io API group, neither added the patch permission for the associated controllers. This commit adds RBAC support for patching cluster/status Signed-off-by: Nolan Brubaker <[email protected]>
🐛 Allow controllers to patch clusters/status
🌱 Devbox update
✨ Allow disabling controllers
When ensuring the paused condition for AWSCluster we where accidently passing in the CAPI Cluster as the object instead of the AWSCluster. This caused a delay in reconciliation as the wrong object was being patched. It also meant we added additional permission that we didn't need. Signed-off-by: Richard Case <[email protected]>
+ rename 2025-01-07-aws-self-managed-feature-gates.md to be consistent with the rest
…aused_fixed 🐛 fix: ensure patching correct object for paused
The EFS e2e test was breaking for 2 reasons: 1. Running out if disk space on the control plane nodes. It only had 8Gb so this has been increased to 16gb 2.The workload being deployed to test EFS was using centos with has been discontinued for a long time now. So changed to use Ubuntu Also small updates to logging for the ELB test. Signed-off-by: Richard Case <[email protected]>
AWSCluster was not reconciling when starting after an upgrade. It had old logic to compare versions and not do anything. We want to reconcile even if there are no changes to the AWSCluster as the ELB logic has changed. Also, there may be other changes like this in future. Change the SetupWithManager logic to be more like the standard we see with other infrastructure providers. Signed-off-by: Richard Case <[email protected]>
Signed-off-by: Nolan Brubaker <[email protected]>
…test 🐛 fix: efs & elb upgrade e2e tests
🌱 Retry boskos account checkouts
📖 Fix links to superseded document
…b-image-go-1.23 🌱 cloudbuild: bump gcb image to get go 1.23
Signed-off-by: Nolan Brubaker <[email protected]>
Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.5.1 to 4.5.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.5.1...v4.5.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.5.1 to 4.5.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.5.1...v4.5.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…-fixes 📖 Document latest release obstacles
…ot/go_modules/github.com/golang-jwt/jwt/v4-4.5.2 🌱 Bump github.com/golang-jwt/jwt/v4 from 4.5.1 to 4.5.2
…ot/go_modules/hack/tools/github.com/golang-jwt/jwt/v4-4.5.2 🌱 Bump github.com/golang-jwt/jwt/v4 from 4.5.1 to 4.5.2 in /hack/tools
Bumps [github.com/golang-jwt/jwt/v5](https://github.com/golang-jwt/jwt) from 5.2.1 to 5.2.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v5.2.1...v5.2.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/hack/tools/github.com/golang-jwt/jwt/v5-5.2.2 🌱 Bump github.com/golang-jwt/jwt/v5 from 5.2.1 to 5.2.2 in /hack/tools
|
@pavansokkenagaraj: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pavansokkenagaraj The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
CAPA EKS reconciler errors when an EKS cluster is deployed with:
endpointPrivateAccess: trueendpointPublicAccess: false...and later, the AWSManagedControlPlane (AWSMCP) resource is updated to change
publicCIDRsfrom a list of IPs to an empty list.This results in a
Reconciler error:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes kubernetes-sigs#5441
Special notes for your reviewer:
Checklist:
Release note: