Skip to content

PCP-5373: Hotfix: added missing code awsclusterroleidentity webhook #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishu2498 merged 2 commits into from
Oct 21, 2025
Merged

PCP-5373: Hotfix: added missing code awsclusterroleidentity webhook #985

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a1b81d
added missing code for awsclusterroleidentity webhook
Kun483 Oct 18, 2025
76365e5
PCP-5293 Adding missing controller-runtime change to webhook
vishu2498 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions api/v1beta2/awsclusterroleidentity_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ var _ = ctrl.Log.WithName("awsclusterroleidentity-resource")
func (r *AWSClusterRoleIdentity) SetupWebhookWithManager(mgr ctrl.Manager) error {
return ctrl.NewWebhookManagedBy(mgr).
For(r).
WithDefaulter(r). // registers webhook.CustomDefaulter
WithValidator(r). // registers webhook.CustomValidator
Complete()
}

Expand All @@ -48,6 +50,11 @@ var (

// ValidateCreate will do any extra validation when creating an AWSClusterRoleIdentity.
func (r *AWSClusterRoleIdentity) ValidateCreate(ctx context.Context, obj runtime.Object) (warnings admission.Warnings, err error) {
r, ok := obj.(*AWSClusterRoleIdentity)
if !ok {
return nil, fmt.Errorf("expected an AWSClusterRoleIdentity object but got %T", r)
}

if r.Spec.SourceIdentityRef == nil {
return nil, field.Invalid(field.NewPath("spec", "sourceIdentityRef"),
r.Spec.SourceIdentityRef, "field cannot be set to nil")
Expand All @@ -71,6 +78,11 @@ func (r *AWSClusterRoleIdentity) ValidateDelete(ctx context.Context, obj runtime

// ValidateUpdate will do any extra validation when updating an AWSClusterRoleIdentity.
func (r *AWSClusterRoleIdentity) ValidateUpdate(ctx context.Context, old runtime.Object, new runtime.Object) (warnings admission.Warnings, err error) {
r, ok := new.(*AWSClusterRoleIdentity)
if !ok {
return nil, fmt.Errorf("expected an AWSClusterRoleIdentity object but got %T", new)
}

oldP, ok := old.(*AWSClusterRoleIdentity)
if !ok {
return nil, apierrors.NewBadRequest(fmt.Sprintf("expected an AWSClusterRoleIdentity but got a %T", old))
Expand All @@ -95,6 +107,10 @@ func (r *AWSClusterRoleIdentity) ValidateUpdate(ctx context.Context, old runtime

// Default will set default values for the AWSClusterRoleIdentity.
func (r *AWSClusterRoleIdentity) Default(ctx context.Context, obj runtime.Object) error {
r, ok := obj.(*AWSClusterRoleIdentity)
if !ok {
return fmt.Errorf("expected an AWSClusterRoleIdentity object but got %T", r)
}
SetDefaults_Labels(&r.ObjectMeta)
return nil
}
Loading