Skip to content

Conversation

@achuribooks
Copy link
Contributor

@achuribooks achuribooks commented Nov 18, 2025

Describe the Change

This PR updates the CAPI Image Builder instructions for Rocky Linux images, providing guidance on how to build images from existing VMs instead of ISOs. It also updates the existing configuration reference and incorporates QOL improvements to RHEL pages where applicable.

NOTE: Additional changes have been made to Vale as a result of this PR: spectrocloud/spectro-vale-pkg#68

Changed Pages

Jira Tickets

🎫 DOC-1461

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@achuribooks achuribooks added auto-backport Enable backport backport-version-4-7 Backport change to version 4.7 labels Nov 18, 2025
@achuribooks achuribooks marked this pull request as ready for review November 18, 2025 04:02
@achuribooks achuribooks requested a review from a team as a code owner November 18, 2025 04:02
@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 08bf17f
🔍 Latest deploy log https://app.netlify.com/projects/docs-spectrocloud/deploys/691befbba3aa6e0008321e9b
😎 Deploy Preview https://deploy-preview-8720--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|591 col 76| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'json -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|592 col 75| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'vmdk -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|593 col 68| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'ovf -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|594 col 86| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'mf -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|595 col 86| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'ova -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|596 col 90| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'sha256 -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|639 col 5| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'ssh -i' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|657 col 52| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'bin -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|671 col 5| [spectrocloud-docs-internal.file-type] Incorrect file type reference. Use 'TAR file'.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|697 col 56| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'bin -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|704 col 56| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'snap -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|884 col 5| [Vale.Spelling] Did you really mean 'Retag'?
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|1107 col 76| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'json -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|1108 col 75| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'vmdk -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|1109 col 68| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'ovf -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|1110 col 86| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'mf -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|1111 col 86| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'ova -rw' with the corresponding long form flag.
docs/docs-content/byoos/capi-image-builder/build-image-vmware/airgap-build/rocky-capi-airgap.md|1112 col 90| [spectrocloud-docs-internal.longform] Avoid using the short form of commands. Replace the short form flag in 'sha256 -rw' with the corresponding long form flag.
docs/docs-content/clusters/data-center/vmware/create-manage-vmware-clusters.md|181 col 401| [spectrocloud-docs-internal.inclusive] Consider avoiding 'master' in favor of more inclusive language.

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 4c208ec
🔍 Latest deploy log https://app.netlify.com/projects/docs-spectrocloud/deploys/6920b3502d570e0008ae2442
😎 Deploy Preview https://deploy-preview-8720--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@rrpolanco rrpolanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is really good. I provided further comments to consider.

@achuribooks achuribooks dismissed rrpolanco’s stale review November 20, 2025 16:15

Changes addressed

@achuribooks achuribooks added the notify-slack Send notification to slack channel of PR ready for review label Nov 20, 2025
@github-actions
Copy link
Contributor

✅ Slack reviewers notified at 2025-11-20T16:36:34Z \n

Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was such a beast PR. I just left some small suggestions, but ignore any suggestions that would take too long to implement.

@achuribooks achuribooks merged commit 33ee7b4 into master Nov 21, 2025
16 checks passed
@achuribooks achuribooks deleted the DOC-1461 branch November 21, 2025 19:00
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 21, 2025
…8720)

* Rough drafting with notes

* Prereqs complete; cleaning scripts, simplifying vmware instructions

* Airgapped addressed; rough draft complete

* Incorporating suggestions from review

* Prettier formatting

* Formatting

* Applying suggestions from code review

* ci: auto-formatting prettier issues

---------

Co-authored-by: achuribooks <[email protected]>
(cherry picked from commit 33ee7b4)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Nov 21, 2025
…8720) (#8740)

* Rough drafting with notes

* Prereqs complete; cleaning scripts, simplifying vmware instructions

* Airgapped addressed; rough draft complete

* Incorporating suggestions from review

* Prettier formatting

* Formatting

* Applying suggestions from code review

* ci: auto-formatting prettier issues

---------


(cherry picked from commit 33ee7b4)

Co-authored-by: Amanda Churi Filanowski <[email protected]>
Co-authored-by: achuribooks <[email protected]>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.7.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Enable backport backport-version-4-7 Backport change to version 4.7 notify-slack Send notification to slack channel of PR ready for review released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants