Skip to content

PLT-1895: Update sso resource to have correct validation and description w… #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SivaanandM merged 1 commit into from
Aug 21, 2025
Merged

PLT-1895: Update sso resource to have correct validation and description w… #642

SivaanandM merged 1 commit into from
Aug 21, 2025

Conversation

@SivaanandM
Copy link
Contributor

@SivaanandM SivaanandM commented Aug 21, 2025

…ithin oidc section (#641)

bulwark-spectrocloud[bot]
bulwark-spectrocloud bot requested changes Aug 21, 2025
View reviewed changes
Copy link

@bulwark-spectrocloud bulwark-spectrocloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ GoSec scan found code issues:

  1. G115: integer overflow conversion int -> uint32, Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:295:26
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:292:26
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:289:24
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_rbac.go:42:19
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_namespace.go:41:20
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_platform_setting.go:395:58
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_platform_setting.go:144:57
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_pcg_ippool.go:207:20
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:73:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:72:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:71:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:70:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:893:43
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:878:37
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:864:14
    • ... (truncated), run gosec locally to capture all failure for the rule G115
  2. G402: TLS InsecureSkipVerify set true., Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/provider.go:208:93
  3. G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32, Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_namespace.go:41:15

Please review these findings and fix the issues before merging.

@SivaanandM SivaanandM requested a review from vishwanaths August 21, 2025 07:04
@SivaanandM SivaanandM changed the base branch from main to tf-patch-v0.24.2 August 21, 2025 07:31
@SivaanandM SivaanandM merged commit 6a7c82b into tf-patch-v0.24.2 Aug 21, 2025
5 of 6 checks passed
@SivaanandM SivaanandM deleted the PLT-1895 branch August 21, 2025 07:32
vishwanaths pushed a commit that referenced this pull request Aug 21, 2025
@SivaanandM @dal13002
TF Patch v0.24.2 (#644)
c51adfc 
* PLT-1887: Fixed eks dynamic cluster provisioning, removed cp entry in api call (#643)

* Fix: update sso resource to have correct validation and description within oidc section (#641) (#642)

Co-authored-by: dal13002 <[email protected]>

* saml email fix

---------

Co-authored-by: dal13002 <[email protected]>
vishwanaths pushed a commit that referenced this pull request Sep 10, 2025
@SivaanandM @dal13002 @dependabot
TF palette 4.7.b (#663)
311af37 
* PLT-1887: Fixed eks dynamic cluster provisioning, removed cp entry in api call (#643)

* Fix: update sso resource to have correct validation and description within oidc section (#641) (#642)

Co-authored-by: dal13002 <[email protected]>

* saml email fix

* PLT:1898- Fixed GoSec issues (#645)

* Fixed G115 Go sec issues

* Fixed G109 and G402

* PLT-1898: Fixed all GO sec issues

* Added windows support for spectro-tf-format script

* refreshed sdk

Signed-off-by: Sivaanand Murugesan <[email protected]>

* refreshed depandabot issue

* PLT-1879: Added LXD support for MAAS Cluster (#651)

* PLT-1879: Added LXD support for MAAS Cluster

* docs

* PLT-1799:Added support for AzureUSSecretCloud in Azure cloud account. (#653)

* refresh sdk

* PLT-1944: Removed depricated spectrocloud_macro resources (#661)

* PLT-1852: Added import support for all resources (#647)

* PLT-1852: Added import support for all resoruces

* Fixed alert import

Signed-off-by: Sivaanand Murugesan <[email protected]>

* fixed import for application profile

* tested cluster group import

* fix

* refreshed docs

* Fixed application import

* refresh template

* Fixed ippool import

* fixed dns map import

* tested backup storage location

* test oci registry

* fixed all resource import

---------

Signed-off-by: Sivaanand Murugesan <[email protected]>

* PLT-1946: Fixed application profile import (#662)

* Bump github.com/hashicorp/go-cty (#659)

Bumps [github.com/hashicorp/go-cty](https://github.com/hashicorp/go-cty) from 1.4.1-0.20200414143053-d3edf31b6320 to 1.5.0.
- [Changelog](https://github.com/hashicorp/go-cty/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hashicorp/go-cty/commits/v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-cty
  dependency-version: 1.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.30.0 to 2.37.0 (#657)

Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.30.0 to 2.37.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-sdk@v2.30.0...v2.37.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2
  dependency-version: 2.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sivaanand Murugesan <[email protected]>

* Bump github.com/google/go-cmp from 0.6.0 to 0.7.0 (#660)

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-cmp
  dependency-version: 0.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump k8s.io/api from 0.23.5 to 0.34.0 (#658)

Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.23.5 to 0.34.0.
- [Commits](kubernetes/api@v0.23.5...v0.34.0)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-version: 0.34.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sivaanand Murugesan <[email protected]>

* Bump github.com/hashicorp/terraform-plugin-docs from 0.16.0 to 0.22.0 (#656)

Bumps [github.com/hashicorp/terraform-plugin-docs](https://github.com/hashicorp/terraform-plugin-docs) from 0.16.0 to 0.22.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-docs/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-docs/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-docs@v0.16.0...v0.22.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-docs
  dependency-version: 0.22.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sivaanand Murugesan <[email protected]>

* fixed dependency refresh issues

* PLT-1947: Fixed import support for sshkey, application, clusterprofile, alert, virtual cluster and application (#664)

* PLT-1886: Fixed cluster profile manifest pack day 2 operation (#665)

* refreshed palette sdk go

* refresh fix

---------

Signed-off-by: Sivaanand Murugesan <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dal13002 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bulwark-spectrocloud bulwark-spectrocloud[bot] bulwark-spectrocloud[bot] requested changes

@vishwanaths vishwanaths Awaiting requested review from vishwanaths

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SivaanandM @dal13002