Skip to content

TF Patch v0.24.2 #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vishwanaths merged 3 commits into from
Aug 21, 2025
Merged

TF Patch v0.24.2 #644

vishwanaths merged 3 commits into from
Aug 21, 2025

Conversation

@SivaanandM
Copy link
Contributor

@SivaanandM SivaanandM commented Aug 21, 2025

No description provided.

bulwark-spectrocloud[bot]
bulwark-spectrocloud bot requested changes Aug 21, 2025
View reviewed changes
Copy link

@bulwark-spectrocloud bulwark-spectrocloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ GoSec scan found code issues:

  1. G115: integer overflow conversion int -> uint32, Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:295:26
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:292:26
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:289:24
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_rbac.go:42:19
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_namespace.go:41:20
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_platform_setting.go:395:58
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_platform_setting.go:144:57
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_pcg_ippool.go:207:20
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:73:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:72:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:71:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:70:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:893:43
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:878:37
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:864:14
    • ... (truncated), run gosec locally to capture all failure for the rule G115
  2. G402: TLS InsecureSkipVerify set true., Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/provider.go:208:93
  3. G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32, Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_namespace.go:41:15

Please review these findings and fix the issues before merging.

@SivaanandM SivaanandM requested a review from vishwanaths August 21, 2025 08:34
bulwark-spectrocloud[bot]
bulwark-spectrocloud bot previously requested changes Aug 21, 2025
View reviewed changes
Copy link

@bulwark-spectrocloud bulwark-spectrocloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ GoSec scan found code issues:

  1. G115: integer overflow conversion int -> uint32, Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:295:26
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:292:26
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:289:24
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_rbac.go:42:19
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_namespace.go:41:20
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_platform_setting.go:395:58
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_platform_setting.go:144:57
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_pcg_ippool.go:207:20
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:73:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:72:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:71:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:70:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:893:43
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:878:37
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:864:14
    • ... (truncated), run gosec locally to capture all failure for the rule G115
  2. G402: TLS InsecureSkipVerify set true., Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/provider.go:208:93
  3. G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32, Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_namespace.go:41:15

Please review these findings and fix the issues before merging.

@SivaanandM SivaanandM dismissed bulwark-spectrocloud[bot]’s stale review August 21, 2025 08:44

We’ve created a separate ticket to address all GoSec issues in the upcoming release:
https://spectrocloud.atlassian.net/browse/PLT-1898

For now, we’ll dismiss this security review and proceed with the patch release as planned.

bulwark-spectrocloud[bot]
bulwark-spectrocloud bot previously requested changes Aug 21, 2025
View reviewed changes
Copy link

@bulwark-spectrocloud bulwark-spectrocloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ GoSec scan found code issues:

  1. G115: integer overflow conversion int -> uint32, Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:295:26
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:292:26
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/kubevirt/schema/virtualmachineinstance/domain_spec.go:289:24
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_rbac.go:42:19
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_namespace.go:41:20
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_platform_setting.go:395:58
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_platform_setting.go:144:57
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_pcg_ippool.go:207:20
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:73:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:72:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:71:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_developer_setting.go:70:30
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:893:43
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:878:37
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/resource_cluster_vsphere.go:864:14
    • ... (truncated), run gosec locally to capture all failure for the rule G115
  2. G402: TLS InsecureSkipVerify set true., Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/provider.go:208:93
  3. G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32, Severity: HIGH
      1. File: /home/runner/_work/bulwark/bulwark/target-repo/spectrocloud/workspace_namespace.go:41:15

Please review these findings and fix the issues before merging.

@SivaanandM SivaanandM dismissed bulwark-spectrocloud[bot]’s stale review August 21, 2025 08:58

We’ve created a separate ticket to address all GoSec issues in the upcoming release:
https://spectrocloud.atlassian.net/browse/PLT-1898

For now, we’ll dismiss this security review and proceed with the patch release as planned.

@vishwanaths vishwanaths merged commit c51adfc into main Aug 21, 2025
6 of 7 checks passed
@vishwanaths vishwanaths deleted the tf-patch-v0.24.2 branch August 21, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishwanaths vishwanaths vishwanaths approved these changes

@bulwark-spectrocloud bulwark-spectrocloud[bot] bulwark-spectrocloud[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SivaanandM @vishwanaths