Skip to content

PLT-1962:Added Fix to honour TLS for Azure secret region #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishwanaths merged 3 commits into from
Sep 18, 2025
Merged

PLT-1962:Added Fix to honour TLS for Azure secret region #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e49da2
PLT-1962:Added Fix to honur TLS for Azure secret region
SivaanandM Sep 17, 2025
1ade25b
reviewable fix
SivaanandM Sep 17, 2025
d51f33f
added docs comment
SivaanandM Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/cluster_eks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ Required:
Optional:

- `additional_labels` (Map of String)
- `ami_type` (String) Specifies the type of Amazon Machine Image (AMI) to use for the machine pool. Available from Palette **v4.7.0**. Valid values are [`AL2_x86_64`, `AL2_x86_64_GPU`, `AL2023_x86_64_STANDARD`, `AL2023_x86_64_NEURON` and `AL2023_x86_64_NVIDIA`]. Defaults to `AL2_x86_64`.
- `ami_type` (String) Specifies the type of Amazon Machine Image (AMI) to use for the machine pool. Valid values are [`AL2_x86_64`, `AL2_x86_64_GPU`, `AL2023_x86_64_STANDARD`, `AL2023_x86_64_NEURON` and `AL2023_x86_64_NVIDIA`]. Defaults to `AL2_x86_64`.
- `az_subnets` (Map of String) Mutually exclusive with `azs`. Use for Static provisioning.
- `azs` (List of String) Mutually exclusive with `az_subnets`.
- `capacity_type` (String) Capacity type is an instance type, can be 'on-demand' or 'spot'. Defaults to 'on-demand'.
Expand Down
6 changes: 3 additions & 3 deletions docs/resources/cluster_maas.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ Required:

Optional:

- `enable_lxd_vm` (Boolean) Whether to enable LXD VM. Default is `false`.
- `enable_lxd_vm` (Boolean) Whether to enable LXD VM. Default is `false`. Available once **Palette with LXD support** is released.


<a id="nestedblock--machine_pool"></a>
Expand All @@ -192,13 +192,13 @@ Optional:
- `control_plane_as_worker` (Boolean) Whether this machine pool is a control plane and a worker. Defaults to `false`.
- `max` (Number) Maximum number of nodes in the machine pool. This is used for autoscaling the machine pool.
- `min` (Number) Minimum number of nodes in the machine pool. This is used for autoscaling the machine pool.
- `network` (Block List, Max: 1) (see [below for nested schema](#nestedblock--machine_pool--network))
- `network` (Block List, Max: 1) Network configuration for the machine pool. Available once **Palette with LXD support** is released. (see [below for nested schema](#nestedblock--machine_pool--network))
- `node` (Block List) (see [below for nested schema](#nestedblock--machine_pool--node))
- `node_repave_interval` (Number) Minimum number of seconds node should be Ready, before the next node is selected for repave. Default value is `0`, Applicable only for worker pools.
- `node_tags` (Set of String) Node tags to dynamically place nodes in a pool by using MAAS automatic tags. Specify the tag values that you want to apply to all nodes in the node pool.
- `taints` (Block List) (see [below for nested schema](#nestedblock--machine_pool--taints))
- `update_strategy` (String) Update strategy for the machine pool. Valid values are `RollingUpdateScaleOut` and `RollingUpdateScaleIn`.
- `use_lxd_vm` (Boolean) Whether to use LXD VM. Default is `false`.
- `use_lxd_vm` (Boolean) Whether to use LXD VM. Default is `false`. Available once **Palette with LXD support** is released.

<a id="nestedblock--machine_pool--instance_type"></a>
### Nested Schema for `machine_pool.instance_type`
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ require (
github.com/hashicorp/terraform-plugin-docs v0.22.0
github.com/hashicorp/terraform-plugin-sdk/v2 v2.37.0
github.com/robfig/cron v1.2.0
github.com/spectrocloud/palette-sdk-go v0.0.0-20250907041328-61dd91d616cc
github.com/spectrocloud/palette-sdk-go v0.0.0-20250917122649-d6a44024432f
github.com/stretchr/testify v1.11.1
gopkg.in/yaml.v3 v3.0.1
gotest.tools v2.2.0+incompatible
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,8 @@ github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ
github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
github.com/skeema/knownhosts v1.3.1 h1:X2osQ+RAjK76shCbvhHHHVl3ZlgDm8apHEHFqRjnBY8=
github.com/skeema/knownhosts v1.3.1/go.mod h1:r7KTdC8l4uxWRyK2TpQZ/1o5HaSzh06ePQNxPwTcfiY=
github.com/spectrocloud/palette-sdk-go v0.0.0-20250907041328-61dd91d616cc h1:wZbQSodOSbp39S5wI8IQJu58I8Rf9rGpdeAVBlMy0Zs=
github.com/spectrocloud/palette-sdk-go v0.0.0-20250907041328-61dd91d616cc/go.mod h1:wIt8g7I7cmcQvTo5ktwhSF0/bWq6uRdxGBs9dwTpleU=
github.com/spectrocloud/palette-sdk-go v0.0.0-20250917122649-d6a44024432f h1:JJJd451FsK5T7UtQFe9Ej/kYqhdVEkcrl24KFtTTkDk=
github.com/spectrocloud/palette-sdk-go v0.0.0-20250917122649-d6a44024432f/go.mod h1:wIt8g7I7cmcQvTo5ktwhSF0/bWq6uRdxGBs9dwTpleU=
github.com/spf13/afero v1.2.2/go.mod h1:9ZxEEn6pIJ8Rxe320qSDBk6AsU0r9pR7Q4OcevTdifk=
github.com/spf13/cast v1.3.1/go.mod h1:Qx5cxh0v+4UWYiBimWS+eyWzqEqokIECu5etghLkUJE=
github.com/spf13/cast v1.5.0 h1:rj3WzYc11XZaIZMPKmwP96zkFEnnAmV8s6XbB2aY32w=
Expand Down
2 changes: 1 addition & 1 deletion spectrocloud/resource_cluster_eks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ func resourceClusterEks() *schema.Resource {
Type: schema.TypeString,
Optional: true,
Default: "AL2_x86_64",
Description: "Specifies the type of Amazon Machine Image (AMI) to use for the machine pool. Available from Palette **v4.7.0**. Valid values are [`AL2_x86_64`, `AL2_x86_64_GPU`, `AL2023_x86_64_STANDARD`, `AL2023_x86_64_NEURON` and `AL2023_x86_64_NVIDIA`]. Defaults to `AL2_x86_64`.",
Description: "Specifies the type of Amazon Machine Image (AMI) to use for the machine pool. Valid values are [`AL2_x86_64`, `AL2_x86_64_GPU`, `AL2023_x86_64_STANDARD`, `AL2023_x86_64_NEURON` and `AL2023_x86_64_NVIDIA`]. Defaults to `AL2_x86_64`.",
},
"capacity_type": {
Type: schema.TypeString,
Expand Down
11 changes: 6 additions & 5 deletions spectrocloud/resource_cluster_maas.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func resourceClusterMaas() *schema.Resource {
Type: schema.TypeBool,
Optional: true,
Default: false,
Description: "Whether to enable LXD VM. Default is `false`.",
Description: "Whether to enable LXD VM. Default is `false`. Available once **Palette with LXD support** is released.",
},
},
},
Expand Down Expand Up @@ -273,12 +273,13 @@ func resourceClusterMaas() *schema.Resource {
Type: schema.TypeBool,
Optional: true,
Default: false,
Description: "Whether to use LXD VM. Default is `false`.",
Description: "Whether to use LXD VM. Default is `false`. Available once **Palette with LXD support** is released.",
},
"network": {
Type: schema.TypeList,
Optional: true,
MaxItems: 1,
Type: schema.TypeList,
Optional: true,
MaxItems: 1,
Description: "Network configuration for the machine pool. Available once **Palette with LXD support** is released.",
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"network_name": {
Expand Down