Skip to content

for supporting speeddb #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rocksdb/_rocksdb.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -2814,7 +2814,7 @@ cdef class BackupEngine(object):
c_backup_dir = path_to_string(backup_dir)
st = backup.BackupEngine_Open(
env.Env_Default(),
backup.BackupableDBOptions(c_backup_dir),
backup.BackupEngineOptions(c_backup_dir),
cython.address(self.engine))

check_status(st)
Expand Down
8 changes: 4 additions & 4 deletions rocksdb/backup.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ from .db cimport DB
from .env cimport Env

# TODO: For rocksdb >= 6.21.0, change to `rocksdb/utilities/backup_engine.h`.
cdef extern from "rocksdb/utilities/backupable_db.h" namespace "rocksdb":
cdef extern from "rocksdb/utilities/backup_engine.h" namespace "rocksdb":
ctypedef uint32_t BackupID

# TODO: For rocksdb >= 6.21.0, rename to `BackupEngineOptions`.
cdef cppclass BackupableDBOptions:
BackupableDBOptions(const string& backup_dir)
cdef cppclass BackupEngineOptions:
BackupEngineOptions(const string& backup_dir)

cdef struct BackupInfo:
BackupID backup_id
Expand All @@ -34,5 +34,5 @@ cdef extern from "rocksdb/utilities/backupable_db.h" namespace "rocksdb":
# TODO: For rocksdb >= 6.21.0, swap order of first two parameters.
cdef Status BackupEngine_Open "rocksdb::BackupEngine::Open"(
Env*,
BackupableDBOptions&,
BackupEngineOptions&,
BackupEngine**)