Skip to content

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Mar 28, 2025

What does this PR do?

Fix test_fts_distributed_compat on MacOS.

lightning raises the following error when initializing the Trainer:

ValueError: You set `strategy=ddp` but strategies from the DDP family
are not supported on the MPS accelerator. Either explicitly set
`accelerator='cpu'` or change the strategy.

Does your PR introduce any breaking changes? If yes, please list them.

None.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

lightning raises the following error when initializing the Trainer:

ValueError: You set `strategy=ddp` but strategies from the DDP family
are not supported on the MPS accelerator. Either explicitly set
`accelerator='cpu'` or change the strategy.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@speediedan speediedan marked this pull request as ready for review March 28, 2025 19:34
@speediedan speediedan self-requested a review as a code owner March 28, 2025 19:34
@speediedan
Copy link
Owner

Thanks for the good catch and appreciated contribution @booxter! Best of luck with your work and let me know if you have any further suggestions.

@speediedan speediedan merged commit 78e6e22 into speediedan:main Mar 28, 2025
11 checks passed
speediedan added a commit that referenced this pull request Mar 29, 2025
…for PretrainedConfig object types, update docker image to use cuda 12.6.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants