Skip to content

Conversation

@GaetanLepage
Copy link
Contributor

What does this PR do?

With the latest pytorch-lightning 2.5.6, ReduceLROnPlateau cannot be imported from lightning.fabric.utilities.types.
Relevant change upstream: Lightning-AI/pytorch-lightning@2.5.5...2.5.6#diff-3c91827ebfece21205d023a4f9b5e1d968ec5b0433b55afdf56810feac32ce30L31

This PR directly imports it from torch.optim.lr_scheduler.
The behavior is unchanged.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@GaetanLepage GaetanLepage changed the title fix ReduceLROnPlateau import from pytorc-lightning fix ReduceLROnPlateau import from pytorch-lightning Nov 8, 2025
@speediedan speediedan merged commit 628437c into speediedan:main Nov 10, 2025
10 checks passed
@speediedan
Copy link
Owner

Thanks for noticing @GaetanLepage! I'll bump the lightning dev sha on the main branch and then cut a new patch release tomorrow with the update.

@GaetanLepage GaetanLepage deleted the fix-lightning branch November 10, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants