Fix k8s-deploy to use registry images from CI/CD#7
Merged
Conversation
- Remove hardcoded 'standard' storageClassName from postgres-pvc.yaml - Now uses default StorageClass (do-block-storage on DigitalOcean) - Fixes "storageclass.storage.k8s.io 'standard' not found" error - Makes PVC more portable across different Kubernetes environments 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Changed k8s-deploy to use update-images (registry) instead of restore-local-images - Added k8s-deploy-local target for local development with local images - Updated minikube-deploy alias to point to k8s-deploy-local - Updated help text to clarify image sources - Now k8s-deploy uses CI/CD registry images by default Fixes: "Container image 'banking-accounts-service:latest' is not present with pull policy of Never" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
k8s-deployto use registry images from CI/CD instead of local images that don't exist.Problem
make k8s-deploywas failing with:Root cause:
k8s-deploywas usingrestore-local-imageswhich sets:imagePullPolicy: Never(local only)banking-accounts-service:latestBut no local images exist - we should use the CI/CD registry images.
Solution
k8s-deploy: Now usesupdate-images→ pulls from registry (ghcr.io/speedscale/microsvc/*)k8s-deploy-local: New target for local development with local imagesminikube-deploy: Updated to use local images (k8s-deploy-local)Usage
make k8s-deploy- Deploy with CI/CD registry images ✅make k8s-deploy-local- Deploy with local images (for dev)make minikube-deploy- Still works for local developmentTest plan
make k8s-deploy- should pull registry images🤖 Generated with Claude Code