Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the user-service latency hotspot around availability-check endpoints (
/api/users/check-username,/api/users/check-email) observed during replay analysis.Changes
usernameExists/emailExistschecks to reduce repeated DB hits under bursty validation trafficinfotodebugcom.banking.userservice: ${APP_LOG_LEVEL:INFO}org.springframework.security: ${SECURITY_LOG_LEVEL:WARN}Findings (Issue #69)
Replay source
backend/user-service/proxymock/recorded-completeEnvironment comparison (before fix)
/api/users/check-usernamearound ~42msdo-nyc1-staging-decoy) showed/api/users/check-usernametimeout at ~10.01s with 100% failure for that endpoint in the sampled runLocal load comparison (before vs after this PR)
Replay command used for both runs:
proxymock replay --test-against localhost:<port> --in proxymock/recorded-complete --times 30 --vus 5/api/users/check-usernameavg/api/users/check-usernamep95Validation
make test(user-service)Issue