Conversation
Moves ownership of frontend/package.json and simulation-client/package.json version bumps from agents/developers to the CI pipeline, eliminating merge conflicts caused by multiple branches independently bumping the same field. Changes: - scripts/version.sh: add `update-frontend` command that syncs only the frontend and simulation-client package.json files from the root VERSION file - Makefile: add `update-frontend-version` target - ci.yml: extend the update-k8s-manifests job to also run `make update-frontend-version` and commit any package.json changes - AGENTS.md: document the two-tier versioning model and explicitly forbid manual bumps of frontend/package.json and simulation-client/package.json - frontend/package.json, simulation-client/package.json: synced to 1.4.1 (current VERSION file value) Made-with: Cursor
kenahrens
force-pushed
the
fix/enforce-service-version-bump-ci
branch
from
f1fe3a0 to
825c1b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend/package.jsonandsimulation-client/package.jsonversion bumps from agents/developers to the CI pipeline, eliminating the recurring merge conflicts caused by multiple branches independently bumping the same version field from the same base.scripts/version.sh update-frontendandmake update-frontend-versionfor syncing those files from the rootVERSIONfile.update-k8s-manifestsCI job (which already had write access and ran only on master) to also sync the package.json versions in the same auto-commit.AGENTS.mdso future agents know exactly which files they should and should not touch.What changed
scripts/version.shupdate-frontendcommand — syncs onlyfrontend/andsimulation-client/package.json fromVERSIONMakefileupdate-frontend-versiontarget.github/workflows/ci.ymlupdate-k8s-manifestsjob now also runsmake update-frontend-versionand commits package.json changesAGENTS.mdfrontend/package.json1.4.1(currentVERSION)simulation-client/package.json1.4.1Test plan
update-k8s-manifestsjob runs on the next push tomasterand produces a commit that updatesfrontend/package.jsonif it is out of sync withVERSIONfrontend/package.jsonbumps appear in subsequent agent PRsMade with Cursor