Skip to content

Add client request that causes 500#10

Merged
kenahrens merged 1 commit intomainfrom
kmansingh/bugs
Jan 8, 2026
Merged

Add client request that causes 500#10
kenahrens merged 1 commit intomainfrom
kmansingh/bugs

Conversation

@kushmansingh
Copy link
Copy Markdown

@kushmansingh kushmansingh commented Dec 10, 2025

Note

Switches default client port to 8080, adds a second rocket lookup with a modified ID and early return, and URL-escapes rocket IDs in HTTP requests.

  • Client (cmd/client/main.go):
    • Change default server address to use port 8080.
    • After fetching one rocket, perform a second GetRocket with rocketID appended with byte 0x7f using context.TODO(), then return early (skips math fact and NASA sections when rockets exist).
  • HTTP Library (lib/http/client.go):
    • URL-escape id parameter in GetRocket requests.

Written by Cursor Bugbot for commit 755482f. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Comment thread cmd/client/main.go
fmt.Printf("Mass: %d kg\n", rocket.MassKg)
}

return nil
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test code accidentally committed causing early return

Debugging code has been added that appends a DEL control character (0x7f) to the rocket ID and makes a request designed to trigger a server 500 error. This test code includes a return nil statement that causes the executeClientCycle function to exit early, completely skipping the GetMathFact and GetNASAData functionality whenever rockets are present. Based on the PR title "Add client request that causes 500," this appears to be intentional test/debugging code that was mistakenly committed.

Fix in Cursor Fix in Web

@kenahrens kenahrens merged commit 90d0c04 into main Jan 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants