Refactor report() to use keyword arguments with predefined units

[nateberkopec]

Summary

Refactors the report() method to use proper keyword arguments with a cleaner signature:

Before:

reporter.report("QueueLatency", 42, integration: :sidekiq, unit: "Seconds", dimensions: [{name: "QueueName", value: "default"}])

After:

reporter.report(metric: :QueueLatency, value: 42, dimensions: {QueueName: "default"})

Changes

New Signature

• metric: - Required symbol for the metric name
• value: - Required value for the metric
• dimensions: - Optional hash of dimensions (no more array of hashes!)
• namespace: - Optional string to override the default namespace

Predefined Units

Units are now predefined in the configuration and cannot be overridden. Each metric has a fixed unit that is automatically applied:

• Count metrics: Workers, EnqueuedJobs, QueueSize, etc.
• Time metrics: QueueLatency (Seconds), RequestQueueTime (Milliseconds)
• Percentage metrics: Utilization

This ensures consistency and prevents accidental misuse of units.

Implementation Details

• Added units configuration hash to Configuration class mapping each metric to its unit
• Updated MetricReporter#report to use proper kwargs signature
• Integration is automatically determined from the metric name via config
• Updated all adapters (Sidekiq, Puma, ActiveJob, Rack) to use new signature
• Updated all test files and test doubles to match

Benefits

• Clearer API: Proper keyword arguments instead of positional or hash-key based
• Type safety: Metric name is explicitly a symbol
• Hash dimensions: Much cleaner than array of hashes
• Unit consistency: Units are predefined and cannot be accidentally changed
• Less repetition: No need to specify units on every call

Test Plan

• All 68 tests pass
• Lint checks pass (flog, flay, standard)
• Updated all adapters and test files
• Added unit mappings to configuration

🤖 Generated with Claude Code