Specify catalog when executing query #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix catalog support in Athena query execution.
Why
The driver previously had catalog support in the connection struct and context functions, but it wasn't being passed to the actual Athena query execution. This meant that even when users set a catalog via
SetCatalog()or connection parameters, the catalog wasn't being used in theQueryExecutionContext, causing queries to run against the wrong catalog.How
Added the missing
Catalog: aws.String(c.catalog)field to theQueryExecutionContextin thestartQuery()function. The catalog infrastructure was already in place - it just wasn't being passed to the Athena API call.Ref