Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Implemented the missing exponentiation operator ** in eldritch-core. This includes updating the parser to support the operator with the correct precedence, implementing the arithmetic logic for integer and floating-point types (including overflow handling and negative exponents), and adding a new OverflowError type. A new test suite tests/exponentiation.rs was added to verify the functionality and cover edge cases.


PR created automatically by Jules for task 17290427632796813611 started by @KCarretto

…ests

- Implements `TokenKind::StarStar` handling in parser with correct precedence.
- Adds `StarStar` logic to `arithmetic.rs` handling Int/Float/Mixed and overflow.
- Adds `OverflowError` to `EldritchErrorKind`.
- Adds comprehensive integration tests in `tests/exponentiation.rs`.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2980    ±0 2980    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#427 2980 2980 0 0 0 0 31.1s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2980 0 0 36.7s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 3 35.2s 36.7s
eldritch: random::string_impl::tests::test_string_uniform 3 35.2s 36.7s
eldritch: random::string_impl::tests::test_string_uniform 3 35.2s 36.7s
eldritch: process::info_impl::tests::test_info_default 3 2.8s 8.2s
eldritch: process::info_impl::tests::test_info_default 3 2.8s 8.2s
eldritch: process::info_impl::tests::test_info_default 3 2.8s 8.2s
eldritch: process::kill_impl::tests::test_process_kill 3 2.5s 7.5s
eldritch: process::kill_impl::tests::test_process_kill 3 2.5s 7.5s
eldritch: process::kill_impl::tests::test_process_kill 3 2.5s 7.5s
eldritch: random::string_impl::tests::test_string_length 3 5.3s 5.6s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto
Copy link
Collaborator

was this someone's feature request? Starlark does not support this feature which is why it has not yet been implemented

@google-labs-jules
Copy link
Contributor Author

was this someone's feature request? Starlark does not support this feature which is why it has not yet been implemented

Understood. I interpreted the absence of ** as a gap in the Python-like dialect, but I see it aligns with the Starlark spec. I will revert the implementation of the ** operator. I will look for other coverage gaps to address instead.

- Revert exponentiation operator `**` implementation to align with Starlark spec.
- Add comprehensive tests for `find_best_match` (variable name suggestion) in `tests/introspection_test.rs`.
- Verify Levenshtein distance logic and thresholding via `NameError` suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants