Claude/http1 doh socks proxy #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the HTTP1 transport to support DNS-over-HTTPS (DOH)
and SOCKS/HTTP proxy configuration, similar to how the gRPC transport
implements these features.
Changes:
- Added HttpClientInner enum to handle multiple client connector types:
* Plain: Basic HTTP connector
* Proxy: HTTP proxy connector
* Doh: DOH-enabled connector (feature-gated)
* DohProxy: Combined DOH + proxy connector (feature-gated)
- Updated HTTP::new() to parse the 'extra' field from transport config
- Added support for "DOH" configuration in extra field (requires grpc-doh feature)
- Added support for "http_proxy" configuration in extra field
- Both features can be combined for DOH + proxy configuration
Configuration format (JSON in extra field):
{
"DOH": "cloudflare", // Optional: Enable DOH
"http_proxy": "socks5://..." // Optional: Enable SOCKS proxy
}
The implementation follows the same pattern as the gRPC transport,
using helper functions extract_uri_from_config() and
extract_extra_from_config() to parse configuration.
The feature flag has been renamed from grpc-doh to doh since it's now shared between both gRPC and HTTP1 transports for DNS-over-HTTPS support. Changes: - Updated Cargo.toml feature definitions (transport and imix) - Updated all #[cfg(feature = "grpc-doh")] to #[cfg(feature = "doh")] - Updated comments and documentation referencing the old flag name - Removed grpc dependency from doh feature (now standalone) The doh feature can now be enabled independently for either transport.
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
hulto
changed the title
KCarretto
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #