-
Notifications
You must be signed in to change notification settings - Fork 0
chore(ci): add GitHub Actions workflow #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
53124e0
fb83fc4
0ba7b50
8891836
af5f886
5547306
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,100 @@ | ||||||||||||||||||||
| name: CI | ||||||||||||||||||||
|
|
||||||||||||||||||||
| on: | ||||||||||||||||||||
| push: | ||||||||||||||||||||
| branches: [ main ] | ||||||||||||||||||||
| pull_request: | ||||||||||||||||||||
| branches: [ main ] | ||||||||||||||||||||
|
|
||||||||||||||||||||
| permissions: | ||||||||||||||||||||
| contents: read | ||||||||||||||||||||
|
|
||||||||||||||||||||
| concurrency: | ||||||||||||||||||||
| group: ci-${{ github.ref }} | ||||||||||||||||||||
| cancel-in-progress: true | ||||||||||||||||||||
|
|
||||||||||||||||||||
| jobs: | ||||||||||||||||||||
| verify: | ||||||||||||||||||||
| name: Verify | ||||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||||
| steps: | ||||||||||||||||||||
| - name: Checkout code | ||||||||||||||||||||
| uses: actions/checkout@v4 | ||||||||||||||||||||
|
|
||||||||||||||||||||
| - name: Set up Go | ||||||||||||||||||||
| uses: actions/setup-go@v5 | ||||||||||||||||||||
| with: | ||||||||||||||||||||
| go-version: stable | ||||||||||||||||||||
| cache: true | ||||||||||||||||||||
|
spencercjh marked this conversation as resolved.
spencercjh marked this conversation as resolved.
spencercjh marked this conversation as resolved.
spencercjh marked this conversation as resolved.
spencercjh marked this conversation as resolved.
|
||||||||||||||||||||
|
|
||||||||||||||||||||
| - name: Download dependencies | ||||||||||||||||||||
| run: make deps | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
spencercjh marked this conversation as resolved.
spencercjh marked this conversation as resolved.
|
||||||||||||||||||||
| - name: Verify dependencies are tidy | ||||||||||||||||||||
| run: git diff --exit-code -- go.mod go.sum | ||||||||||||||||||||
|
|
||||||||||||||||||||
| - name: Setup golangci-lint | ||||||||||||||||||||
| uses: golangci/golangci-lint-action@v7 | ||||||||||||||||||||
| with: | ||||||||||||||||||||
| version: v2.10 | ||||||||||||||||||||
| args: --help | ||||||||||||||||||||
| verify: false | ||||||||||||||||||||
|
Comment on lines
+36
to
+41
|
||||||||||||||||||||
| - name: Setup golangci-lint | |
| uses: golangci/golangci-lint-action@v7 | |
| with: | |
| version: v2.10 | |
| args: --help | |
| verify: false | |
| - name: Install golangci-lint | |
| run: | | |
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest |
Copilot
AI
Mar 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E job also uses go-version: stable, which can make runs non-reproducible (especially for go test and module resolution) compared to the pinned Go version in go.mod/build job. Prefer go-version-file: go.mod or the same pinned Go version across jobs.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/spencercjh/spec-forge | ||
|
|
||
| go 1.26.0 | ||
| go 1.26 | ||
|
|
||
| require ( | ||
| github.com/getkin/kin-openapi v0.133.0 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR metadata says this change is only adding CI, but this PR also includes non-CI changes (provider name constants, factory switch updates, e2e test change, and go.mod edit). Please confirm these are intended to be in this PR (or split them) so reviewers can track non-CI behavior changes separately.