lnmsg/bolt12: merkle root signing, onion_wire types#10597
Open
f321x wants to merge 5 commits into
Open
Conversation
f321x
changed the title
…ation and schnorr-sign over tlvs, implicit en/decode utf8 fields, schnorr signature verification. Co-Authored-By: f321x <f@f321x.com>
Validate points to be valid ECPubkeys in lnmsg._read_primitive_field. There are failing bolt12 test vectors that contain offers with invalid points.
were consuming too much from the fd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the signing scheme required for bolt 12 (
invoice_requestandinvoicesignatures).Adds bolt 12 types to onion_wire.csv.
Test coverage will indirectly increase further when introducing the bolt 12 test vectors.