qml: improve history list scrolling performance#10615
Open
f321x wants to merge 3 commits into
Open
Conversation
Disables the Material design ovelay background on HistoryItemDelegate to prevent flickering when scrolling and loading the app. Sets reuseItems and cacheBuffer in history ElListView to reuse delegate instances instead of destroying and re-creating them each time they become (in-)visible. This makes scrolling through a large history smoother.
From the Qt docs (https://doc.qt.io/qt-6/qml-qtquick-image.html#sourceSize-prop): ``` Unlike the width and height properties, which scale the painting of the image, this property sets the maximum number of pixels stored for the loaded image so that large images do not use more memory than necessary. ``` When we want to display e.g. the clock icon in iconSizeLarge we only need to keep iconSizeLarge with/height pixels in memory instead of the whole 256x256 icon.
Don't update the fiat values during scrolling through the history with the thing on the right side (drag scrolling), this should improve the performance of the list when doing a quick drag scroll.
09b5f43 to
3d8faba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some performance improvements attempting to make scrolling through a large history smoother on QML.