ci: code review: improvements (use system prompt, give more permissions)#10649
Open
f321x wants to merge 3 commits into
Open
ci: code review: improvements (use system prompt, give more permissions)#10649f321x wants to merge 3 commits into
f321x wants to merge 3 commits into
Conversation
With `--dangerously-skip-permissions` claude can also execute commands. I thought the `-p` flag for headless usage already did that, but apparently not (looking at https://code.claude.com/docs/en/headless). As it runs in the isolated CI container this seems fine and might make it more powerful (e.g. allowing it to run and modify unittests to verify behavior).
By appending the prompt to the system prompt it is prioritized over the actual user prompt (the diff), so it apparently is more persistent in the context. This e.g. could improve the output if a large diff is provided as the actual task (system prompt) is treated with higher priority than the large diff itself.
If the model is logged it makes sense to log the effort level as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skimming through the headless docs I think these changes could improve the results of the CI:
--dangerously-skip-permissionsso it can actually execute and modify code